style: Use require.ErrorIs whenever possible #1303
Conversation
alarso16
force-pushed
the
alarso16/error-contains
branch
from
38af157 to
1734bc4
Compare
| ctx: ctx, | ||
| rules: vmtest.ForkToRules(upgradetest.NoUpgrades), | ||
| expectedErr: "atomic input failed verification", | ||
| expectedErr: avax.ErrNilTransferableInput, |
There was a problem hiding this comment.
This is the specific error we were checking, but I'm not sure it's good practice to rely on an error "so far away"
| } | ||
| } else { | ||
| switch { | ||
| case ethHeader.ParentBeaconRoot != nil: |
There was a problem hiding this comment.
This is only moved because the test fails for a different error than what it was intending to check.
|
Just a question (and I'll do an actual review) - I remember talking about the |
That package is used to share errors between packages to avoid circular dependencies - for the errors I added, I didn't actually need to move them, but I definitely could. I think the package is necessary for the existing errors though |
I see - I didn't realize it was just for errors that would create circular dependencies! |
|
By the way the vmwrrors package should be can be removed entirely -- obviously not for this PR but if you take a look at my uplift PR Josh explained how. |
3 participants
Why this should be merged
Works to follow avalanchego's linter whenever possible. Some of the ErrorContains really tested geth code, making it difficult to remove.
How this works
Uses sentinel errors and nolint clauses.
How this was tested
Existing UT
Need to be documented?
No
Need to update RELEASES.md?
No